Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Float16Array constructor for SharedArrayBuffer #1025

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

petamoriken
Copy link
Owner

Fixes #1024

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (3b6ab31) 87.02% compared to head (46b82d7) 87.04%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   87.02%   87.04%   +0.01%     
==========================================
  Files          12       12              
  Lines         771      772       +1     
  Branches      146      147       +1     
==========================================
+ Hits          671      672       +1     
  Misses         54       54              
  Partials       46       46              
Flag Coverage Δ
unittests 87.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Float16Array.mjs 87.44% <100.00%> (ø)
src/_util/is.mjs 94.28% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petamoriken petamoriken merged commit d9190ed into master Aug 13, 2023
12 checks passed
@petamoriken petamoriken deleted the fix/shared-array-buffer branch August 13, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float16Array constructor doesn't work with SharedArrayBuffers
1 participant