Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z1 Robot arm from Unitree #342

Open
wants to merge 15 commits into
base: future
Choose a base branch
from
Open

Z1 Robot arm from Unitree #342

wants to merge 15 commits into from

Conversation

siilats
Copy link

@siilats siilats commented Nov 10, 2022

Please find it attached

jhavl added a commit that referenced this pull request Apr 19, 2023
@petercorke petercorke changed the base branch from master to future August 10, 2024 01:33
@petercorke
Copy link
Owner

Hi @siilats thanks for your interest in the toolbox and apologies for the very late response.

I'm happy to accept new robots to the toolbox, but this PR has got many aspects, and is quite large +50,000 lines which is a bit daunting. Could you pare this back a bit, keep the robot model, but don't include the notebooks, or save the notebooks after you've cleared the output. Is tray.csv really of general interest? There are also changes to Robot.py and tools/xacro/__init__.py which I don't fully understand, or worry about what their consequences would be for other models.

QuantuMope added a commit to HorizonRoboticsInternal/robotics-toolbox-python that referenced this pull request Nov 12, 2024
QuantuMope added a commit to HorizonRoboticsInternal/robotics-toolbox-python that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants