Skip to content

Fix task step touch goal success conditions#33

Merged
peterso merged 1 commit intopeterso:mainfrom
4ntn:fix_touch_goal
May 5, 2025
Merged

Fix task step touch goal success conditions#33
peterso merged 1 commit intopeterso:mainfrom
4ntn:fix_touch_goal

Conversation

@4ntn
Copy link
Contributor

@4ntn 4ntn commented May 5, 2025

Finish the step if the tap count required or the long tap duration is reached. (In addition to timeout)

Signed-off-by: Antón Casas <antoncasas@eprosima.com>
Copy link
Owner

@peterso peterso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix has been tested and the touches for the touch_goal task are registered as complete.
The success evaluation still needs to be improved to handle whether the initial touch was within the desired region, e.g., BtnA, or BtnB, or Background (not BtnA or BtnB). Similarly, the final touch should be evaluated for the region, e.g., BtnA or BtnB, or Backgound. Swipe direction should also be added with a pass fail condition.

@peterso peterso merged commit 14cb01e into peterso:main May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants