Fix task step touch goal success conditions#33
Merged
peterso merged 1 commit intopeterso:mainfrom May 5, 2025
Merged
Conversation
Signed-off-by: Antón Casas <antoncasas@eprosima.com>
peterso
approved these changes
May 5, 2025
Owner
peterso
left a comment
There was a problem hiding this comment.
This fix has been tested and the touches for the touch_goal task are registered as complete.
The success evaluation still needs to be improved to handle whether the initial touch was within the desired region, e.g., BtnA, or BtnB, or Background (not BtnA or BtnB). Similarly, the final touch should be evaluated for the region, e.g., BtnA or BtnB, or Backgound. Swipe direction should also be added with a pass fail condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish the step if the tap count required or the long tap duration is reached. (In addition to timeout)