Task step rendering in web interface dependent on score#35
Merged
peterso merged 1 commit intopeterso:mainfrom May 6, 2025
Merged
Task step rendering in web interface dependent on score#35peterso merged 1 commit intopeterso:mainfrom
peterso merged 1 commit intopeterso:mainfrom
Conversation
Signed-off-by: Antón Casas <antoncasas@eprosima.com>
peterso
approved these changes
May 6, 2025
Owner
peterso
left a comment
peterso
left a comment
There was a problem hiding this comment.
LGTM. A further improvement would be to draw a red circle on the task progress bar on the Core2 screen for failed tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show an "x" symbol and color red the task steps that are completed with a score of 50% or less.
This should solve the visualization issue of completed task steps with good/bad scores (related to #33).