-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose setuptools and wheel version flags for use with non-vendored Pips. #1895
Comments
@jsirois as part of this, should we add |
@danxmoran I'm not sure. Can you supply a backtrace for the error you hit? (You may need PEX_VERBOSE=1 to expose this depending where you hit the error) It's unclear to me exactly where the surgery is needed and there is a plan to do better for locks (include a sub-lock for every sdist that pins its build requirements). Also, can you confirm the full range of use cases you have. Is it just the class of sdists with 2to3 where you want to use new Pip, old setuptools & wheel or are there other cases? |
@jsirois no error - I was trying my hand at implementing this by plumbing It's just this one use-case. Noted that we could work around the EDIT: I found another case of |
In the meantime, |
When using non-vendored Pip (i.e.: specifying a custom `--pip-version`), you can now override the versions of setuptools and wheel Pex bootstraps for Pip with the existing `--extra-pip-requirement` option and the override will be respected. Trying to override setuptools or wheel for vendored Pip will raise an error however since its versions are specialized to support all Pex resolve features under Python 2.7. Fixes pex-tool#1895
When using non-vendored Pip (i.e.: specifying a custom `--pip-version`), you can now override the versions of setuptools and wheel Pex bootstraps for Pip with the existing `--extra-pip-requirement` option and the override will be respected. Trying to override setuptools or wheel for vendored Pip will raise an error however since its versions are specialized to support all Pex resolve features under Python 2.7. Fixes pex-tool#1895
Right now these are hard-coded but it would be good to allow experimentation with these by end users:
https://github.com/pantsbuild/pex/blob/63592214c569c03b60c59766f96fdd2832e698b6/pex/pip/version.py#L77-L86
Pex does not rely on them in any direct way; so a user should be able to try out / pick up a bug fix in either or even downgrade when prodlems are discovered but not fixed.
The text was updated successfully, but these errors were encountered: