Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom setuptools & wheel versions. #2514

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Aug 21, 2024

When using non-vendored Pip (i.e.: specifying a custom --pip-version),
you can now override the versions of setuptools and wheel Pex bootstraps
for Pip with the existing --extra-pip-requirement option and the
override will be respected. Trying to override setuptools or wheel for
vendored Pip will raise an error however since its versions are
specialized to support all Pex resolve features under Python 2.7.

Fixes #1895

When using non-vendored Pip (i.e.: specifying a custom `--pip-version`),
you can now override the versions of setuptools and wheel Pex bootstraps
for Pip with the existing `--extra-pip-requirement` option and the
override will be respected. Trying to override setuptools or wheel for
vendored Pip will raise an error however since its versions are
specialized to support all Pex resolve features under Python 2.7.

Fixes pex-tool#1895
@jsirois
Copy link
Member Author

jsirois commented Aug 21, 2024

@danxmoran had requested this feature via Pants some time ago; so adding Pants reviewers for this one.

Copy link
Collaborator

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@jsirois jsirois merged commit 4c45f05 into pex-tool:main Aug 26, 2024
26 checks passed
@jsirois jsirois deleted the issues/1895 branch August 26, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose setuptools and wheel version flags for use with non-vendored Pips.
2 participants