Skip to content

Commit

Permalink
[CI] Bump mosaicml version from 0.10 to 0.12 (ray-project#33080)
Browse files Browse the repository at this point in the history
ray-project#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
  • Loading branch information
bveeramani authored and peytondmurray committed Mar 22, 2023
1 parent bffef99 commit fffa627
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .buildkite/pipeline.build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@
# Horovod needs to be installed separately (needed for API ref imports)
- ./ci/env/install-horovod.sh
# See https://stackoverflow.com/questions/63383400/error-cannot-uninstall-ruamel-yaml-while-creating-docker-image-for-azure-ml-a
- pip install mosaicml==0.10.1 --ignore-installed
- pip install mosaicml==0.12.1 --ignore-installed
- ./ci/ci.sh build

- label: ":octopus: Tune multinode tests"
Expand Down
1 change: 0 additions & 1 deletion ci/env/install-dependencies.sh
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@ install_pip_packages() {

# Additional Train test dependencies.
if [ "${TRAIN_TESTING-}" = 1 ] || [ "${DOC_TESTING-}" = 1 ]; then
rm -rf "${SITE_PACKAGES}"/ruamel* # https://stackoverflow.com/questions/63383400/error-cannot-uninstall-ruamel-yaml-while-creating-docker-image-for-azure-ml-a
pip install -U -c "${WORKSPACE_DIR}"/python/requirements.txt -r "${WORKSPACE_DIR}"/python/requirements/ml/requirements_train.txt
fi

Expand Down
4 changes: 1 addition & 3 deletions python/ray/train/tests/test_mosaic_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def test_monitor_callbacks(ray_start_4_cpus):
from ray.train.mosaic import MosaicTrainer

# Test Callbacks involving logging (SpeedMonitor, LRMonitor)
from composer.callbacks import SpeedMonitor, LRMonitor, GradMonitor
from composer.callbacks import SpeedMonitor, LRMonitor

trainer_init_config = {
"max_duration": "1ep",
Expand All @@ -270,7 +270,6 @@ def test_monitor_callbacks(ray_start_4_cpus):
trainer_init_config["callbacks"] = [
SpeedMonitor(window_size=3),
LRMonitor(),
GradMonitor(),
]

trainer = MosaicTrainer(
Expand All @@ -289,7 +288,6 @@ def test_monitor_callbacks(ray_start_4_cpus):
"wall_clock/val",
"wall_clock/total",
"lr-DecoupledSGDW/group0",
"grad_l2_norm/step",
]
for column in columns_to_check:
assert column in metrics_columns, column + " is not found"
Expand Down
2 changes: 1 addition & 1 deletion python/requirements/ml/requirements_train.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

-r requirements_dl.txt

mosaicml==0.10.1
mosaicml==0.12.1
mlflow==1.30.0
tensorboardX==2.4.1

Expand Down

0 comments on commit fffa627

Please sign in to comment.