Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Add object detection example #31553

Merged
merged 73 commits into from
Mar 8, 2023
Merged

[AIR] Add object detection example #31553

merged 73 commits into from
Mar 8, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jan 10, 2023 •
edited
Loading

Signed-off-by: Balaji Veeramani balaji@anyscale.com

Depends on

Why are these changes needed?

We don't have any examples showing how to do object detection with AIR. This PR adds an example of how to fine-tune a Torch object detection model.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

bveeramani and others added 9 commits November 21, 2022 21:00
@bveeramani
Rename "model_state_dict" to "model"
5984f1e
@bveeramani
Revert "Rename "model_state_dict" to "model""
8f58490 
This reverts commit 5984f1e.
@bveeramani
Merge remote-tracking branch 'upstream/master'
63432eb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
2c33947 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
89694a0 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe60ca3 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
d45ae9a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
c703dfc 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Create main.py
d7be156 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as draft January 10, 2023 02:22
@bveeramani bveeramani mentioned this pull request Jan 14, 2023
Closed
7 tasks
amogkam
amogkam reviewed Jan 14, 2023
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bveeramani! lgtm, left a couple of comments. Let's move forward with converting this to a notebook and adding this to the documentation!

main.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@bveeramani
Merge remote-tracking branch 'upstream/master' into detection-example
97c90ab 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
81dd25c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fba788e 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update annotations.py
de05655 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Revert "Update annotations.py"
fd2ff91 
This reverts commit de05655.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Initial commit
3203f0c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Create main.md
e95d314 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Delete main.py
1e1acf2 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Delete files
0841235 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
amogkam
amogkam reviewed Jan 28, 2023
View reviewed changes
main.md Outdated Show resolved Hide resolved
@bveeramani
Create main.ipynb
4a8a802 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Address review comments
28fa37c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update utils.py
2f5fd21 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into promote-create-ra…
679f3b1 
…gged

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into promote-create-ra…
e3a7630 
…gged

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Add main.ipynb
6bf5bb3
@bveeramani
Add example to index
2a1bcf9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update mosaicml version
45843e1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update files
30a393c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into detection-example
41d0cbf 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update BUILD
3e3dc75 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update torch_detection.ipynb
5987a75 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update install-dependencies.sh
e6f874f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update stuff
1e00b78 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Mar 7, 2023
Merged
7 tasks
amogkam pushed a commit that referenced this pull request Mar 7, 2023
@bveeramani
[CI] Bump mosaicml version from 0.10 to 0.12 (#33080)
57a909d 
#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into detection-example
476235d 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update torch_detection.ipynb
0501256 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update torch_detection.ipynb
32d1bc7 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@amogkam amogkam merged commit 8c3b4a3 into ray-project:master Mar 8, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@bveeramani @ProjectsByJackHe
[CI] Bump mosaicml version from 0.10 to 0.12 (ray-project#33080)
911beaf 
ray-project#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@bveeramani @amogkam @ProjectsByJackHe
[AIR] Add object detection example (ray-project#31553)
3770543 
We don't have any examples showing how to do object detection with AIR. This PR adds an example of how to fine-tune a Torch object detection model.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@bveeramani @edoakes
[CI] Bump mosaicml version from 0.10 to 0.12 (ray-project#33080)
8b0bb8b 
ray-project#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@bveeramani @amogkam @edoakes
[AIR] Add object detection example (ray-project#31553)
2f2ea4d 
We don't have any examples showing how to do object detection with AIR. This PR adds an example of how to fine-tune a Torch object detection model.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@bveeramani @peytondmurray
[CI] Bump mosaicml version from 0.10 to 0.12 (ray-project#33080)
fffa627 
ray-project#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@bveeramani @amogkam @peytondmurray
[AIR] Add object detection example (ray-project#31553)
50d2e64 
We don't have any examples showing how to do object detection with AIR. This PR adds an example of how to fine-tune a Torch object detection model.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@bveeramani @elliottower
[CI] Bump mosaicml version from 0.10 to 0.12 (ray-project#33080)
2d4a20f 
ray-project#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: elliottower <elliot@elliottower.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@bveeramani @amogkam @elliottower
[AIR] Add object detection example (ray-project#31553)
a687ec5 
We don't have any examples showing how to do object detection with AIR. This PR adds an example of how to fine-tune a Torch object detection model.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@bveeramani @ProjectsByJackHe
[CI] Bump mosaicml version from 0.10 to 0.12 (ray-project#33080)
6e174e6 
ray-project#31553 requires torchmetrics>=0.8, but the current mosaicml version requires torchmetrics<8. This PR upgrades the mosaicml version.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@bveeramani @amogkam @ProjectsByJackHe
[AIR] Add object detection example (ray-project#31553)
66ed5ba 
We don't have any examples showing how to do object detection with AIR. This PR adds an example of how to fine-tune a Torch object detection model.

---------

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Amog Kamsetty <amogkam@users.noreply.github.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee left review comments

@angelinalg angelinalg angelinalg approved these changes

@amogkam amogkam amogkam approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@gjoliver gjoliver Awaiting requested review from gjoliver

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@clarkzinzow clarkzinzow Awaiting requested review from clarkzinzow

@jjyao jjyao Awaiting requested review from jjyao

@jianoaix jianoaix Awaiting requested review from jianoaix

@c21 c21 Awaiting requested review from c21

@jiaodong jiaodong Awaiting requested review from jiaodong

Assignees

@scottjlee scottjlee

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bveeramani @Yard1 @amogkam @scottjlee @angelinalg