Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Add TorchDetectionPredictor #32199

Merged
merged 25 commits into from
Feb 8, 2023
Merged

[AIR] Add TorchDetectionPredictor #32199

merged 25 commits into from
Feb 8, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Feb 2, 2023 •
edited
Loading

Depends on:

Why are these changes needed?

TorchPredictor doesn't work with TorchVision detection models because they return List[Dict[str, torch.Tensor]] instead of torch.Tensor. This PR adds a TorchDetectionPredictor so users don't have to extend TorchPredictor themselves.

Related issue number

Closes #32064

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
3203f0c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Address review comments
28fa37c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update utils.py
2f5fd21 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into promote-create-ra…
679f3b1 
…gged

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into promote-create-ra…
e3a7630 
…gged

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Address review comments
10d78cf 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update tensor_extension.py
0d331c5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update tensor_extension.py
328b3f8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into promote-create-ra…
694764e 
…gged

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Initial commit
9855e94 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'dtype-optional' into detection-predictor
bbbda1f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as draft February 2, 2023 23:35
@bveeramani
Add TorchDetectionPredictor
22b3aa9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani marked this pull request as ready for review February 3, 2023 01:18
@bveeramani bveeramani mentioned this pull request Feb 3, 2023
Merged
12 tasks
@bveeramani bveeramani self-assigned this Feb 3, 2023
@bveeramani
Fix test
ab67b37 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Address review comments
750cc0b 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'dtype-optional' into detection-predictor
edf14b8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'promote-create-ragged' into detection-predictor
43693e5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@amogkam amogkam self-assigned this Feb 7, 2023
amogkam
amogkam reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks overall lgtm! left a few comments

python/ray/train/torch/torch_detection_predictor.py Show resolved Hide resolved
python/ray/train/torch/torch_detection_predictor.py Outdated Show resolved Hide resolved
python/ray/train/tests/test_torch_detection_predictor.py Outdated Show resolved Hide resolved
python/ray/train/tests/test_torch_detection_predictor.py Show resolved Hide resolved
@bveeramani
Address review comments
dd3a9eb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update torch_detection_predictor.py
6ecf830 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Fix Bazel
6374151 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into detection-predictor
c85f5d1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Feb 8, 2023
@bveeramani
Merge remote-tracking branch 'upstream/master' into detection-predictor
2f41527 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update BUILD
bdf28f9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update torch_predictor.py
163d2af 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into detection-predictor
a55bc0a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update torch_predictor.py
cea988f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@amogkam amogkam merged commit 53260af into ray-project:master Feb 8, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@bveeramani @edoakes
[AIR] Add TorchDetectionPredictor (ray-project#32199)
28c9f91 
TorchPredictor doesn't work with TorchVision detection models because they return List[Dict[str, torch.Tensor]] instead of torch.Tensor. This PR adds a TorchDetectionPredictor so users don't have to extend TorchPredictor themselves.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@clarkzinzow clarkzinzow Awaiting requested review from clarkzinzow

@jjyao jjyao Awaiting requested review from jjyao

@jianoaix jianoaix Awaiting requested review from jianoaix

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@c21 c21 Awaiting requested review from c21

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@Yard1 Yard1 Awaiting requested review from Yard1

Assignees

@amogkam amogkam

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AIR] Add TorchDetectionPredictor
2 participants
@bveeramani @amogkam