tests(phpcs): Update PHPCS to 3.4.1 and fix phpunit tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the Travis Config a bit to enable composer install caching. Should reduce the random composer install fails from above. |
|
The composer caching settings have brought down the Travis test time now again, even if we use the PHPCS dev version for now. |
klausi
changed the title
truls1502
approved these changes
Mar 30, 2019
pfrenssen
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://www.drupal.org/project/coder/issues/3040784
PHPIUnit tests are broken, if we update PHPCS then they are fixed again.
This is wasting resources because a git clone of PHP_CodeSniffer is 200MB, so I will open an issue there that they should release 3.4.1