tests(phpcs): Update PHPCS to 3.4.1 and fix phpunit tests

.travis.yml

@@ -1,7 +1,14 @@
+# For PHP 5.5 and lower testing we need to stick to Ubuntu 14.04.
 dist: trusty
 language: php
 sudo: false
 
+# Cache composer vendor directories to speed up the composer install step.
+cache:
+  directories:
+    - $HOME/.composer/cache
+    - vendor
+
 matrix:
   fast_finish: true
   include:
@@ -11,24 +18,15 @@ matrix:
     - php: 7.0
     - php: 7.1
     - php: 7.2
-    - php: nightly
-    - php: hhvm
-
-  allow_failures:
-    - php: hhvm
-    - php: nightly
+    - php: 7.3
 
 before_install:
   # Speed up build time by disabling Xdebug when its not needed.
   - phpenv config-rm xdebug.ini || echo 'No xdebug config.'
-  # Circumvent a bug in the travis HHVM image - ships with incompatible PHPUnit.
-  - if [[ $TRAVIS_PHP_VERSION == hhv* ]]; then composer self-update; fi
-  - if [[ $TRAVIS_PHP_VERSION == hhv* ]]; then composer require phpunit/phpunit:~4.0; fi
-  - if [[ $TRAVIS_PHP_VERSION == hhv* ]]; then composer install; fi
 
 before_script:
-  # We don't have a composer.lock file because we always want to test with
-  # latest dependencies.
+  # Running composer install without a lock file will also update cached
+  # dependencies in vendor.
   - composer install
 
 script:

coder_sniffer/Drupal/Test/bad/BadUnitTest.php

@@ -32,7 +32,7 @@ public function getErrorList($testFile = NULL)
                         3 => 2,
                         4 => 1,
                         5 => 1,
-                        6 => 2,
+                        6 => 1,
                         7 => 1,
                         8 => 1,
                         9 => 1,

composer.json

@@ -12,7 +12,7 @@
     "require": {
         "php": ">=5.4.0",
         "ext-mbstring": "*",
-        "squizlabs/php_codesniffer": "^3.0.1",
+        "squizlabs/php_codesniffer": "^3.4.1",
         "symfony/yaml": ">=2.0.0"
     },
     "autoload": {