Sqlite data types #11663
Merged
Sqlite data types #11663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite does not enforce static data types, but follows type affinity conventions. The rules are explained here: www.sqlite.org/datatype3.html. The column data types chosen maximize database compatibility.
|
Could you please update CHANGELOG.md |
basilfx
force-pushed
the
sqlite-data-types
branch
from
d7bc4cf to
ba3fc2b
Compare
|
Adapted |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lists of column types has been extended. However, not all column types conversions exist for SQLite.
This PR adds support for the additional column types. While SQLite has no statically typed columns, they have dynamic typing and use the column name for determining the type affinity. The rules are explained in Section 2.0. I have chosen column names that match MySQL the most, while still adhering to the type affinity rules. This way, as little as possible information is lost when converting from SQLite to another DBMS.
I also extended the dialect tests.
Together with phalcon/phalcon-devtools#639, I have been using this patch for almost two weeks without problems. I successfully converted from MySQL -> Phalcon Devtool Migrations -> SQLite (clean migration).