Improve support for PDO Sqlite migrations #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know PDO SQLite migrations are not fully working (due to ALTER table limitations), but the following three commits should at least improve support for running migrations (I successfully converted structure from MySQL to SQLite).
NOW()
in PHP'sdate()
. The latter is already used inMigrations.php
.Example of issue the last commit fixes (note the file name is used as schema in the CREATE TABLE statement):
I have also a patch ready that converts the missing column types for SQLite (Blob, Double, etc). I'll contribute this to CPhalcon.