Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16283 title prepend #16284

Merged
merged 18 commits into from
Feb 26, 2023
Merged

T16283 title prepend #16284

merged 18 commits into from
Feb 26, 2023

Conversation

niden
Copy link
Member

@niden niden commented Feb 20, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Html\Helper\Title::prepend to correctly prepend text in subsequent calls

Thanks

@niden niden requested a review from Jeckerson February 20, 2023 14:56
@niden niden self-assigned this Feb 20, 2023
@niden niden linked an issue Feb 20, 2023 that may be closed by this pull request
[BUG]: Multiple times tag->title()->prepend() do not make title what i expect #16283
Closed
Jeckerson
Jeckerson reviewed Feb 21, 2023
View reviewed changes
ext/php_phalcon.h Outdated Show resolved Hide resolved
@Jeckerson Jeckerson merged commit 0b29ba6 into phalcon:5.0.x Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Multiple times tag->title()->prepend() do not make title what i expect
2 participants
@niden @Jeckerson