Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1969 fix get-started link bug #1983

Closed
wants to merge 1 commit into from

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented Jun 29, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@zdz2101 zdz2101 requested a review from bms63 June 29, 2023 20:30
@zdz2101 zdz2101 linked an issue Jun 29, 2023 that may be closed by this pull request
@bms63
Copy link
Collaborator

bms63 commented Jun 29, 2023

We should put this in the news for the hotfix

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Jun 29, 2023

We should put this in the news for the hotfix

Is this "big" enough to warrant its own hotfix? Or should we bundle the other small bugs as well into it?

@github-actions
Copy link

Code Coverage

Package Line Rate Health
admiral 99%
Summary 99% (4198 / 4254)

@bms63
Copy link
Collaborator

bms63 commented Jun 29, 2023

#1962 was going to get bundled with this fix, but @rossfarrugia, @manciniedoardo and @bundfussr is #1962 really needed quickly? Doesn't it warrant a hotfix or can we wait for a bit longer to see if anything elese pops up

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Jun 29, 2023

#1962 was going to get bundled with this fix, but @rossfarrugia, @manciniedoardo and @bundfussr is #1962 really needed quickly? Doesn't it warrant a hotfix or can we wait for a bit longer to see if anything elese pops up

Maybe bundle #1966 too, so (#1962, #1966, #1969) and ship these 3 as hotfix?

@manciniedoardo
Copy link
Collaborator

#1962 was going to get bundled with this fix, but @rossfarrugia, @manciniedoardo and @bundfussr is #1962 really needed quickly? Doesn't it warrant a hotfix or can we wait for a bit longer to see if anything elese pops up

Yes it would be great if it was released as a hotfix asap, thank you

@bms63
Copy link
Collaborator

bms63 commented Jun 30, 2023

So this should go to the patch branch as well

@zdz2101 zdz2101 closed this Jun 30, 2023
@bms63 bms63 deleted the 1969_get_started_bug@devel branch September 12, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Get Started not linked properly set up
3 participants