Bug: derive_param_tte() fails for dplyr 1.1.0

[bundfussr]

What happened?

If dlpyr 1.1.0 is used, some tests for derive_param_tte() fail. They pass for dplyr 1.0.5 (minimum version required by admiraldev) and also for dplyr 1.1.1.

In derive_param_tte()

        full_join(
          mutate(by_groups, temp_dummy = 1),
          mutate(source_datasets[[i]], temp_dummy = 1),
          by = "temp_dummy",
          relationship = "many-to-many"
        ) %>%
        select(-temp_dummy)

should be replaced by

        crossing(
          by_groups,
          source_datasets[[i]]
        )

This is simpler and avoids the dplyr issue.

Session Information

No response

Reproducible Example

No response

[SamantaTarun]

I'd like to look into this

[rossfarrugia]

I'd like to look into this

Please go ahead. We'd like this completed by end of next week (30th) if possible. Let us know if any issues.

[SamantaTarun]

@rossfarrugia should i replace the whole block?

full_join( mutate(by_groups, temp_dummy = 1), mutate(source_datasets[[i]], temp_dummy = 1), by = "temp_dummy", relationship = "many-to-many" ) %>% select(-temp_dummy)

[rossfarrugia]

that's how i understand it from what Ben wrote above, but test it out and see if it gives same results to be sure and still passes all our tests at tests/testthat/test-derive_param_tte.R.