Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: derive_param_tte() fails for dplyr 1.1.0 #1988

Closed
wants to merge 10 commits into from
Closed

fix: derive_param_tte() fails for dplyr 1.1.0 #1988

wants to merge 10 commits into from

Conversation

SamantaTarun
Copy link

@SamantaTarun SamantaTarun commented Jun 30, 2023

Closes #1962
Linked PR: #1962
What happened?

If dlpyr 1.1.0 is used, some tests for derive_param_tte() fail. They pass for dplyr 1.0.5 (minimum version required by admiraldev) and also for dplyr 1.1.1.

In derive_param_tte()

full_join(
  mutate(by_groups, temp_dummy = 1),
  mutate(source_datasets[[i]], temp_dummy = 1),
  by = "temp_dummy",
  relationship = "many-to-many"
) %>%
select(-temp_dummy)

should be replaced by

crossing(
  by_groups,
  source_datasets[[i]]
)

@bms63
Copy link
Collaborator

bms63 commented Jul 5, 2023

We fisnished this one in #1997. Thanks again for trying to fix this - I still recommend running through the Onboarding issue to get some more experience on how we operate. - #1839

This test issue might be a good one to jump on - #1466

@bms63 bms63 closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: derive_param_tte() fails for dplyr 1.1.0
2 participants