fix: cleanup frontend dependencies, tsconfig #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
Cleans up the frontend
tsconfig
and missingdependencies
that were incorrectly placed indevDependencies
, preventing standalone Docker builds with--production
from working. Fixed #652💡 Proposed Changes
devDependencies
todependencies
tsconfig
for production builds🎯 Reviewer Focus
yarn install
first (Make surenode_modules
doesnt exist)dev-docker-compose
yarn && yarn codegen && yarn test
locally💚 Did You...
- [ ] Update migrations (if required)- [ ] Regenerate graphql schema and types (if required)- [ ] Verify the app builds locally?- [ ] Manually test the changes on different browsers/devices?Note
Move several runtime-needed packages from devDependencies to dependencies and adjust tsconfig by dropping Jest types and excluding codegen.ts.
devDependencies
todependencies
:@types/libsodium-wrappers-sumo
,@types/lodash
,@types/react-icons
,@types/zxcvbn
,autoprefixer
.types
entry forjest
infrontend/tsconfig.json
.exclude
to includecodegen.ts
.Written by Cursor Bugbot for commit 740fb39. This will update automatically on new commits. Configure here.