Skip to content

Conversation

rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Oct 3, 2025

🔍 Overview

Cleans up the frontend tsconfig and missing dependencies that were incorrectly placed in devDependencies, preventing standalone Docker builds with --production from working. Fixed #652

💡 Proposed Changes

  • Move runtime dependencies from devDependencies to dependencies
  • clean up tsconfig for production builds

🎯 Reviewer Focus

  • Verify that the frontend Docker build works without running yarn install first (Make sure node_modules doesnt exist)
  • Verify that the dev setup still works:
    • Build and run dev-docker-compose
    • Run yarn && yarn codegen && yarn test locally

💚 Did You...

  • Ensure linting passes (code style checks)?
  • Update dependencies and lockfiles (if required)
    - [ ] Update migrations (if required)
    - [ ] Regenerate graphql schema and types (if required)
    - [ ] Verify the app builds locally?
    - [ ] Manually test the changes on different browsers/devices?

Note

Move several runtime-needed packages from devDependencies to dependencies and adjust tsconfig by dropping Jest types and excluding codegen.ts.

  • Dependencies:
    • Move runtime-needed packages from devDependencies to dependencies: @types/libsodium-wrappers-sumo, @types/lodash, @types/react-icons, @types/zxcvbn, autoprefixer.
  • TypeScript config:
    • Remove types entry for jest in frontend/tsconfig.json.
    • Expand exclude to include codegen.ts.

Written by Cursor Bugbot for commit 740fb39. This will update automatically on new commits. Configure here.

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes standalone Docker production builds by moving runtime dependencies from devDependencies to dependencies and cleaning up the TypeScript configuration for production builds.

  • Moved type definitions and runtime dependencies to the correct dependencies section
  • Removed jest types from production tsconfig and excluded codegen.ts from compilation
  • Fixed Docker build compatibility with --production flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/tsconfig.json Removed jest types from production config and excluded codegen.ts
frontend/package.json Moved runtime type definitions and autoprefixer to dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nimish-ks
Copy link
Member

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


nimish-ks and others added 2 commits October 7, 2025 13:13
… included in Docker context (#660)

Co-authored-by: Rohan Chaturvedi <rohan.chaturvedi@protonmail.com>
@rohan-chaturvedi rohan-chaturvedi changed the title fix: cleanup dependencies, tsconfig fix: cleanup frontend dependencies, tsconfig Oct 7, 2025
@nimish-ks nimish-ks merged commit b651890 into main Oct 7, 2025
7 checks passed
@nimish-ks nimish-ks deleted the fix--frontend-build branch October 7, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Production build fails without dev dependencies

2 participants