Skip to content

chore: add .dockerignore file for frontend Dockerfile #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

chore: add .dockerignore file for frontend Dockerfile #660

merged 2 commits into from
Oct 7, 2025

Conversation

nimish-ks
Copy link
Member

@nimish-ks nimish-ks commented Oct 7, 2025 •
edited
Loading

🔍 Overview

Add a simple .dockerignore exclusion list to prevent dev dependencies from making their way into the production docker build.

@nimish-ks nimish-ks self-assigned this Oct 7, 2025
@nimish-ks
Copy link
Member Author

Note: Just wanted to confirm that when a .dockerignore excluding node_modules and .next added the CI frontend docker build would break. This confirms my suspicions that dependencies from when we run unit tests were making into their way into the build via the COPY . . in the frontend Dockerfile.

@nimish-ks nimish-ks changed the base branch from main to fix--frontend-build October 7, 2025 09:21
@nimish-ks nimish-ks changed the title chore: add .dockerignore file to prevent unnecessary files from being… chore: add .dockerignore file for frontend Dockerfile Oct 7, 2025
@nimish-ks nimish-ks merged commit 9eb1dc0 into fix--frontend-build Oct 7, 2025
@nimish-ks nimish-ks deleted the feat--add-dockerignore branch October 7, 2025 09:25
nimish-ks added a commit that referenced this pull request Oct 7, 2025
@rohan-chaturvedi @nimish-ks
fix: cleanup frontend dependencies, tsconfig (#653)
b651890 
* fix: cleanup dependencies, tsconfig

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>

* chore: add .dockerignore file to prevent unnecessary files from being included in Docker context (#660)

Co-authored-by: Rohan Chaturvedi <rohan.chaturvedi@protonmail.com>

---------

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Co-authored-by: Nimish <85357445+nimish-ks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohan-chaturvedi rohan-chaturvedi rohan-chaturvedi approved these changes

Assignees

@nimish-ks nimish-ks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nimish-ks @rohan-chaturvedi