Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insufficient use of vegas in game #102

Closed
pixelzoom opened this issue Apr 10, 2018 · 4 comments
Closed

insufficient use of vegas in game #102

pixelzoom opened this issue Apr 10, 2018 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

Related to #99

Area Model is not using common game components.

• Level-selection buttons are at GameAreaScreenView line 102. It should be using LevelSelectionItemNodeDeprecated, or the newer LevelSelectionButton which will soon be replacing LevelSelectionItemNodeDeprecated.

• Status bar is implemented in GameStatusBar. It should be using the well-established ScoreboardBar, which will need to be enhanced to show the score format used by Area Model.

• The score display is currently using ProgressIndicator, which is deprecated. It should be using ScoreDisplayDiscreetStars.

@pixelzoom
Copy link
Contributor Author

Beside the fact that game design should inform vegas, the other big reasons for using vegas components are a11y and phet-io. If you use common-code, you'll get these features for free when the common-code is instrumented. When you roll your own, you create more a11y and phet-io work.

@jonathanolson
Copy link
Contributor

I'll presumably use the (planned) bar once it has the "Score: {stars}" option, the LevelSelectionButton (new one). I'll also add a dissolve (instead of a wipe back) when Start Over is pressed.

@jonathanolson
Copy link
Contributor

Switched to LevelSelectionButton above.

@jonathanolson
Copy link
Contributor

Completed switch with the above commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants