Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory test for 1.3 release. #155

Closed
Tracked by #1133
pixelzoom opened this issue Jul 31, 2024 · 4 comments
Closed
Tracked by #1133

Memory test for 1.3 release. #155

pixelzoom opened this issue Jul 31, 2024 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

For #154.

@pixelzoom pixelzoom self-assigned this Jul 31, 2024
@pixelzoom
Copy link
Contributor Author

This sim has a memory leak, probably related to LocalizedStringProperty.

Tested on macOS 14.5 + Chrome 127.0.6533.74
https://phet-dev.colorado.edu/html/balancing-chemical-equations/1.3.0-dev.4/phet/balancing-chemical-equations_all_phet.html?fuzz
Heap snapshots at 1-minute intervals.

screenshot_3443

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 1, 2024

There were several leaks in GameFeedbackPanel, all related to LocalizedStringProperty, that were fixed in 6777d55.

I don't see any other Text or RichText nodes that require disposal, as they are all associated with Nodes that are isDisposable: false. Ditto for ProfileColorProperty.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Aug 1, 2024

Tested on macOS 14.5 + Chrome 127.0.6533.74
https://phet-dev.colorado.edu/html/balancing-chemical-equations/1.3.0-dev.5/phet/balancing-chemical-equations_all_phet.html?fuzz
Heap snapshots at 1-minute intervals (numbered 2-11).

Memory leaks are resolved. The heap size stabilizes at ~54 MB.

screenshot_3445




I'll leave this issue open for verification during the QA process.

@pixelzoom
Copy link
Contributor Author

It's been awhile, and QA usually does memory tests. So I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant