Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out the mass input listener from the screen view #104

Closed
zepumph opened this issue Feb 21, 2024 · 3 comments
Closed

Factor out the mass input listener from the screen view #104

zepumph opened this issue Feb 21, 2024 · 3 comments
Assignees
@samreid
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Feb 21, 2024

From #78, adding mass drag sounds directly in the screen view helped see the break in modularity.
@zepumph zepumph self-assigned this Feb 21, 2024
@AgustinVallejo AgustinVallejo self-assigned this Feb 21, 2024
samreid added a commit to phetsims/density-buoyancy-common that referenced this issue Apr 17, 2024
@samreid
Factor out BackgroundEventTargetListener.ts, see phetsims/buoyancy#104
27e2f87
@samreid
Copy link
Member

samreid commented Apr 17, 2024

I factored out BackgroundEventTargetListener and it seems to be working in my testing. I noted several TODOs that would be good to check in about. Feel free to finish it up.

@samreid samreid removed their assignment Apr 17, 2024
@zepumph
Copy link
Member Author

zepumph commented Apr 17, 2024

I looked at things, and decided to "go all in" with two main changes:

  1. Provided only specific items of screen view (which allowed us to get rid of the parametric type).
  2. Use the constructor, and more instance fields to implement TInputListener.

Feel free to close.

zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Apr 17, 2024
@zepumph
change signature and remove TODOs, phetsims/buoyancy#104
afec5fe 
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Apr 17, 2024
@zepumph
use constructor and implement TInputListener, phetsims/buoyancy#104
c63499f 
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
@zepumph zepumph assigned samreid and unassigned zepumph Apr 17, 2024
@samreid
Copy link
Member

samreid commented Apr 17, 2024

Looks good, thanks. Closing.

@samreid samreid closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @zepumph @AgustinVallejo