Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UI Sound #78

Closed
zepumph opened this issue Jan 25, 2024 · 5 comments
Closed

Support UI Sound #78

zepumph opened this issue Jan 25, 2024 · 5 comments
Assignees
@AgustinVallejo

Comments

@zepumph
Copy link
Member

zepumph commented Jan 25, 2024

No description provided.

@zepumph zepumph changed the title Add UI Sound Support UI Sound Jan 25, 2024
@zepumph zepumph transferred this issue from phetsims/density-buoyancy-common Jan 25, 2024
@zepumph
Copy link
Member Author

zepumph commented Jan 25, 2024

@DianaTavares and I discussed that we should also add pickup/drop sounds to the objects in the play area.

@AgustinVallejo AgustinVallejo self-assigned this Feb 5, 2024
AgustinVallejo added a commit that referenced this issue Feb 9, 2024
@AgustinVallejo
Turning on default UI sounds, see #78
b46607e
@AgustinVallejo
Copy link
Contributor

AgustinVallejo commented Feb 9, 2024 •
edited
Loading

Now supporting default UI sound. Will keep adding drag-drop sounds later (perfect opportunity to try out our RichDragListener)

I'll be looking at this document for referencing on the UI sound stuff

@AgustinVallejo AgustinVallejo added the dev:help-wanted Extra attention is needed label Feb 16, 2024
@AgustinVallejo AgustinVallejo mentioned this issue Feb 16, 2024
Closed
@AgustinVallejo AgustinVallejo removed the dev:help-wanted Extra attention is needed label Feb 20, 2024
AgustinVallejo added a commit to phetsims/density-buoyancy-common that referenced this issue Feb 20, 2024
@AgustinVallejo
Adding default grab and release sounds for blocks, see phetsims/buoya…
309d03d 
…ncy#78
@AgustinVallejo
Copy link
Contributor

Above commit adds default drag and drop. Marking for review and possibly closing

@AgustinVallejo
Copy link
Contributor

Remember to add this in density as well!

@zepumph zepumph mentioned this issue Feb 21, 2024
Closed
AgustinVallejo added a commit to phetsims/density that referenced this issue Feb 23, 2024
@AgustinVallejo
Adding sound to density, see phetsims/buoyancy#78
7ef7f5d
@AgustinVallejo
Copy link
Contributor

Closing as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zepumph @AgustinVallejo