Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up linting with better cache files #1467

Closed
samreid opened this issue Sep 20, 2024 · 1 comment
Closed

Speed up linting with better cache files #1467

samreid opened this issue Sep 20, 2024 · 1 comment
Assignees

Comments

@samreid
Copy link
Member

samreid commented Sep 20, 2024

From a TODO in #1356:

  // TODO: https://github.com/phetsims/chipper/issues/1356 do we need a different cache for different repos or repo combos? We get a speed boost when using repos.join as a filename key
  args.push( '--cache', '--cache-location', '../chipper/eslint/cache/.eslintcache' );

We used to do this, I don't recall why we stopped. An experiment showed that using one mini-cache per repo gave a speed boost, especially when lint-everything is running one repo per process.

@samreid samreid self-assigned this Sep 20, 2024
samreid added a commit that referenced this issue Sep 20, 2024
@samreid
Copy link
Member Author

samreid commented Sep 20, 2024

The benefit from this is negligible, closing.

@samreid samreid closed this as completed Sep 20, 2024
samreid added a commit that referenced this issue Sep 20, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 17, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant