Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript project references enhancements #1469

Closed
8 tasks done
samreid opened this issue Sep 20, 2024 · 4 comments
Closed
8 tasks done

TypeScript project references enhancements #1469

samreid opened this issue Sep 20, 2024 · 4 comments

Comments

@samreid
Copy link
Member

samreid commented Sep 20, 2024

In #1356 we added project references. Here is a list of next steps for improvements and enhancements. Note that some are already tracked elsewhere such as #1468 and #1467 and #1466

@samreid samreid self-assigned this Sep 20, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Sep 23, 2024
…ipper#1469

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit to phetsims/axon that referenced this issue Sep 23, 2024
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit to phetsims/phet-core that referenced this issue Sep 23, 2024
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
@zepumph
Copy link
Member

zepumph commented Sep 23, 2024

A starting point for build tool tsconfig files using project references:

Subject: [PATCH] s
---
Index: tsconfig.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/tsconfig.json b/tsconfig.json
--- a/tsconfig.json	(revision bd7e3b12ee074da1814a7faee8c27c73ffe6b9da)
+++ b/tsconfig.json	(date 1727116313517)
@@ -1,12 +1,5 @@
 {
   "extends": "../chipper/tsconfig-core.json",
-  "include": [
-    "js/**/*",
-    "images/**/*",
-    "mipmaps/**/*",
-    "sounds/**/*",
-    "test/**/*"
-  ],
   "compilerOptions": {
     "module": "NodeNext",
     "esModuleInterop": true,
@@ -16,6 +9,9 @@
   "references": [
     {
       "path": "../chipper/tsconfig/buildjson"
+    },
+    {
+      "path": "../chipper/tsconfig/buildtools"
     }
   ]
 }
\ No newline at end of file
Index: tsconfig/all/tsconfig.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/tsconfig/all/tsconfig.json b/tsconfig/all/tsconfig.json
--- a/tsconfig/all/tsconfig.json	(revision bd7e3b12ee074da1814a7faee8c27c73ffe6b9da)
+++ b/tsconfig/all/tsconfig.json	(date 1727115357915)
@@ -9,6 +9,9 @@
       "path": "../buildjson"
     },
     {
+      "path": "../buildtools"
+    },
+    {
       "path": "../../../acid-base-solutions"
     },
     {
@@ -392,12 +395,12 @@
     {
       "path": "../../../pendulum-lab"
     },
-//    {
-//      "path": "../../../perennial"
-//    },
-//    {
-//      "path": "../../../perennial-alias"
-//    },
+    //    {
+    //      "path": "../../../perennial"
+    //    },
+    //    {
+    //      "path": "../../../perennial-alias"
+    //    },
     {
       "path": "../../../ph-scale"
     },
@@ -422,12 +425,12 @@
     {
       "path": "../../../phet-io-wrappers"
     },
-//    {
-//      "path": "../../../phet-lib"
-//    },
-//    {
-//      "path": "../../../phet-vite-demo"
-//    },
+    //    {
+    //      "path": "../../../phet-lib"
+    //    },
+    //    {
+    //      "path": "../../../phet-vite-demo"
+    //    },
     {
       "path": "../../../phetcommon"
     },
Index: tsconfig/buildtools/tsconfig.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/tsconfig/buildtools/tsconfig.json b/tsconfig/buildtools/tsconfig.json
new file mode 100644
--- /dev/null	(date 1727117724924)
+++ b/tsconfig/buildtools/tsconfig.json	(date 1727117724924)
@@ -0,0 +1,19 @@
+{
+  "extends": "../../tsconfig-core.json",
+  // Entry points from build.json, see chipper/build.json
+  "include": [
+
+    "../../../perennial-alias/js/common/**/*",
+    "../../../chipper/js/common/**/*",
+    "../../../chipper/js/grunt/**/*",
+    //    "../../../chipper/js/phet-io/**/*",
+    "../../../chipper/js/scripts/**/*",
+    //    "../../../chipper/js/sim-tests/**/*",
+    "../../../phet-core/js/types/**/*"
+  ],
+  "references": [
+    //    {
+    //      "path": "../buildjson"
+    //    }
+  ]
+}
\ No newline at end of file

@zepumph
Copy link
Member

zepumph commented Sep 23, 2024

Working from the above patch now

zepumph added a commit to phetsims/perennial that referenced this issue Sep 23, 2024
phetsims/chipper#1469

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit that referenced this issue Sep 23, 2024
#1469

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit that referenced this issue Sep 30, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Oct 4, 2024
zepumph added a commit to phetsims/aqua that referenced this issue Oct 8, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Oct 8, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 11, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 11, 2024
zepumph added a commit to phetsims/kite that referenced this issue Oct 11, 2024
zepumph added a commit to phetsims/aqua that referenced this issue Oct 11, 2024
zepumph added a commit that referenced this issue Oct 11, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 11, 2024
samreid added a commit to phetsims/aqua that referenced this issue Oct 11, 2024
@samreid samreid assigned zepumph and unassigned samreid Oct 11, 2024
zepumph added a commit to phetsims/brand that referenced this issue Oct 11, 2024
zepumph added a commit to phetsims/kite that referenced this issue Oct 11, 2024
zepumph added a commit that referenced this issue Oct 11, 2024
zepumph added a commit to phetsims/number-line-operations that referenced this issue Oct 11, 2024
@zepumph zepumph assigned samreid and unassigned zepumph Oct 11, 2024
@zepumph
Copy link
Member

zepumph commented Oct 11, 2024

All TODOs pointing here are complete. Last couple of items over to @samreid for comment.

@zepumph zepumph assigned samreid and unassigned samreid Oct 11, 2024
samreid added a commit to phetsims/perennial that referenced this issue Oct 11, 2024
@samreid
Copy link
Member Author

samreid commented Oct 11, 2024

Make sure simula rasa updates its package.json to point to tsconfig. and its tsconfig is good.

I wasn't really sure what that meant, but I reviewed the changes in simula-rasa, and tested grunt create-sim --repo=test-repo --author="Test Author" and it worked OK and tsc -b worked well in it.

Closing.

@samreid samreid closed this as completed Oct 11, 2024
zepumph added a commit to phetsims/perennial that referenced this issue Oct 14, 2024
zepumph added a commit that referenced this issue Oct 14, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
phetsims/chipper#1469

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
samreid pushed a commit to phetsims/perennial that referenced this issue Oct 21, 2024
samreid pushed a commit that referenced this issue Oct 23, 2024
#1469

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants