Skip to content

Commit

Permalink
move TODOs, phetsims/chipper#1469
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Oct 8, 2024
1 parent 030dd58 commit 9137035
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion js/common/ChipperVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const assert = require( 'assert' );
const fs = require( 'fs' );

/**
* TODO: remove this workaround jsdoc once this file is in TypeScript, https://github.com/phetsims/chipper/issues/1469
* TODO: remove this workaround jsdoc once this file is in TypeScript, https://github.com/phetsims/perennial/issues/369
* @type
*/
module.exports = ( function() {
Expand Down
1 change: 0 additions & 1 deletion tsconfig-chipper.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// Entry points for checked out resources that may not be on main, but need to version together. These must be usable
// by chipper
"include": [
// TODO should we just use a reference just to perennial-alias/tsconfig.json? https://github.com/phetsims/chipper/issues/1469
"js/common/**/*",
"js/import-shared/**/*",
"js/grunt/tasks/util/**/*",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
// TODO: Remove devDependencies from chipper and use many of them from perennial-alias, https://github.com/phetsims/chipper/issues/1469
// TODO: Remove devDependencies from chipper and use many of them from perennial-alias, https://github.com/phetsims/perennial/issues/364
// TODO: If you want to use optionize() in perennial, we need to move it from phet-core to perennial-alias. Or JO HELP, https://github.com/phetsims/chipper/issues/1469
// TODO: Doesn't tsconfig-node and core need to be in perennial-alias? https://github.com/phetsims/chipper/issues/1469
// TODO: Doesn't shared/tsconfig-node and core need to be in perennial-alias? https://github.com/phetsims/perennial/issues/364
"extends": "../chipper/tsconfig/shared/tsconfig-node.json",
"include": [
"js/**/*",
Expand Down

0 comments on commit 9137035

Please sign in to comment.