Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address missing tandems #205

Closed
pixelzoom opened this issue Nov 2, 2023 · 3 comments
Closed

Address missing tandems #205

pixelzoom opened this issue Nov 2, 2023 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

Similar to phetsims/my-solar-system#281, I figured we should do this for keplers-laws while this painful process is still fresh in my mind.

Running with:
http://localhost:8080/studio/?sim=keplers-laws&phetioPrintMissingTandems&locales=*&keyboardLocaleSwitcher&phetioWrapperDebug=true&phetioElementsDisplay=all&phetioValidation=true

... there are currently 200 missing required tandems, 3177 missing optional tandems.

@pixelzoom pixelzoom self-assigned this Nov 2, 2023
pixelzoom added a commit that referenced this issue Nov 2, 2023
pixelzoom added a commit that referenced this issue Nov 2, 2023
pixelzoom added a commit that referenced this issue Nov 2, 2023
pixelzoom added a commit that referenced this issue Nov 2, 2023
pixelzoom added a commit that referenced this issue Nov 2, 2023
@pixelzoom
Copy link
Contributor Author

After the above commits, we now have 0 missing required tandems.

There were 10 missing tandems responsible for the 200 missing tandems messages in the original console output. That's a lot of noise.

Onward to removing phet-io.validation: false from package.json.

@pixelzoom
Copy link
Contributor Author

I'll leave this open to verify that there are no CT problems.

@pixelzoom
Copy link
Contributor Author

CT is happy. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant