Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to permanently turn off the "Neutral" indicator #102

Closed
pixelzoom opened this issue Feb 6, 2020 · 2 comments
Closed

make it possible to permanently turn off the "Neutral" indicator #102

pixelzoom opened this issue Feb 6, 2020 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

2/6/20 design meeting discussion:

Client request: Ability to remove the word “neutral” that appears in the beaker when the probe detects a pH of 7.
CM: This is not entirely straightforward because visibility of “Neutral” is controlled by the sim, depending on pH. If the client sets its visibleProperty to false, the sim will eventually set it to true. Options:
Wrap this neutralIndicatorNode inside of another Node, and let the client control the wrapper (easy).
Query parameter to disable the feature
PhET-iO specific Property to disable the feature (least desirable)
Decision: Do option (1).

@pixelzoom
Copy link
Contributor Author

Done. @arouinfar please verify in master. To test:

  1. Run in Studio
  2. Navigate to phScale.macroScreen.view.neutralIndicatorNode.visibleProperty
  3. Switch between 'Water' and other solutes with visibleProperty true and false

@arouinfar
Copy link
Contributor

Looks good in master @pixelzoom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants