-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument Flatirons easter egg #246
Comments
Although a very similar problem to phetsims/ph-scale#102, I ended up solving it differently because BackgroundNode, which houses the flatirons image, had no PhET-iO instrumentation at all. Instead of making that overly complicated, I just added a single Property to the screen view to be able to toggle whether or not the flat irons can be shown.
I don't love the name currently, and with it was something more like Please review. |
The new property is behaving well, thanks! Two tweaks:
|
Done |
Thanks @zepumph. Looks good in master, closing. |
For #244
When the altitude is 1500-1700m, an image of the Flatirons appears (Drag & Lab screens). Clients may want to remove this easter egg, so it needs to be instrumented. We probably can't just slap a
visibleProperty
on it because the model needs to be in control of its visibility.This seems somewhat parallel to
phScale.macroScreen.view.neutralIndicatorNode
which was handled by wrapping it in another Node that the client can hide, see phetsims/ph-scale#102.The text was updated successfully, but these errors were encountered: