Skip to content

Commit

Permalink
Updated REVIEW comments, see phetsims/area-model-common#99
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Apr 18, 2018
1 parent 48e3476 commit 81a47c4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions checklists/code_review_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ Because JavaScript lacks visibility modifiers (public, protected, private), PhET
- [ ] Put qualifiers in parenthesis after the annotation, for example:
- [ ] To qualify that something is read-only, use `@public (read-only)`. This indicates that the given property (AND its value) should not be changed by outside code (e.g. a Property should not have its value changed)
- [ ] To qualify that something is public to a specific repository, use (for example) `@public (scenery-internal)`
- [ ] For something made public solely for a11y, use `@public (a11y)`
- [ ] For something made public solely for phet-io, use `@public (phet-io)`
- [ ] Separate multiple qualifiers with commas. For example: `@public (scenery-internal, read-only)`

- [ ] For JSDoc-style comments, the annotation should appear in context like this:
Expand Down

0 comments on commit 81a47c4

Please sign in to comment.