-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav bar disappears when zoomed in (Chrome) #1507
Comments
This sounds like a general problem with pan-and-zoom, so assigning to @jessegreenberg. @Nancy-Salpepi can you reproduce this with other sims on master? |
Very strange! I don't know why pan and zoom would cause this, it doesn't do any hiding of things to optimize. Also, see how the nav bar is invisible from seconds 7-9 in this video recording and then pops into view at 9 seconds. So it is not related to dialogs. I think this is more of a rendering problem - like either scenery or the browser doesn't know to redraw some contents. I think we will need help from JO here. |
For what it is worth - I can easily reproduce this in Windows 10 Chrome Version 107.0.5304.107 (Official Build) (64-bit). But when I remove |
@pixelzoom on master I was able to make the nav bar disappear in Geometric Optics, Gravity and Orbits, and Density by zooming in and then using the mouse to drag down until I can see the bottom of the screen. The nav bar appears when I move the mouse across the bottom of the screen. I tested with mac + chrome and Win10 + chrome. GaOnavbar.mp4 |
Happens with the Performance dialog as well. |
Raising priority. Blocks publication until someone says otherwise. |
Does it happen in already published simulations on the website? |
Yes it does @kathy-phet. I was able to produce the problem just now with Density, Gravity and Orbits, CCK-AC, and Geometric Optics. |
After discussion with @kathy-phet, we decided that this issue is not blocking. Since some published sims are currently affected, we can fix GO:B when we fix the others. That said, this is still a high priority issue. @jonathanolson please transfer this issue to the appropriate common repo and investigate. |
Transferring this issue to scenery. |
Another data point, I am seeing this in energy-skate-park. Like #1507 (comment), it makes use of |
@pixelzoom @AgustinVallejo FYI that I see this issue on Win10 + chrome for MSS (phetsims/qa#1008) |
@jonathanolson - Let's prioritize this scenery issue for after you finish the "file size reduction" common work. I don't want to block publication for this bug, but let's see if we can address it next iteration (or late this iteration JO if the file size stuff wraps up earlier). (FYI - @brent-phet @marlitas) |
I added an emergent task in Monday to track this. It's assigned to @jonathanolson and put it on for next iteration. |
Noting that I see this issue with Area Model Algebra (phetsims/qa#1041) and Area Model Multiplication (phetsims/qa#1042). |
@jessegreenberg noted phetsims/projectile-data-lab#237 might be related. Somehow there were no tasks for this current iteration for this, I've added it to my current goals as emergent (sorry about it falling off the radar). |
Problematic in Chrome Canary (no fix coming soon), and it indeed seems like a browser bug (adjusting a color within the SVG element causes it to appear, looks like a repaint issue). |
…VGBlock usage to support lazy creation, and SimDisplay chromium guard to refresh SVG during pan/zoom, see #1507
…VGBlock usage to support lazy creation, and SimDisplay chromium guard to refresh SVG during pan/zoom, see phetsims/scenery#1507
I think I've figured out a decent workaround above. It forces SVG refreshes while panning/zooming on Chrome (or other Chromium-based browsers). @Nancy-Salpepi can you see if this is fixed on main for you? |
Looks better on main to me. |
Looks great to me!! |
Thanks! Closing. |
Test device
MacBook Air m1 chip
Operating System
13.0.1
Browser
Chrome 107.0.5304.121
Problem description
For phetsims/qa#858, when zoomed in, if I exit a dialog using either the Esc or Return key, the nav bar is missing. Once I move the mouse or press Tab, it reappears.
I see this issue with published GO as well. I wasn't able to reproduce this with Safari or with other sims that have keyboard nav (published GFLB or Ratio and Proportion). @KatieWoe was also able to reproduce with Win11 + chrome.
Steps to reproduce
This is also seen with the keyboard shortcuts dialog, and in the PhET menu--when exiting the Check for Updates or About dialogs.
Visuals
missingnavbar.mp4
The text was updated successfully, but these errors were encountered: