-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightmode #32
base: develop
Are you sure you want to change the base?
Add nightmode #32
Conversation
…unce_logic use async queue to only execute one command at the time
Implemented night mode for milight led.
Update fork
- Save the mode when set to white mode - Only set color and brightnes if turned on
I will change the ci tests when you reviewed the code an you would merge it. |
I see two options:
I personally would vote for the 2. solution, but @mwittig had once the plan to split the plugin by devices, than the 1. approach would be better. So bottom line we will do it one way or the other. If you adjust the tests it would be nice if you also add some for the ActionHandler. |
Yeah I thought about the second solution. |
Ok, do it like this 👍 |
…t to hyperion, not working yet.
…s setting brightness still need to be implemented.
…d license property, added bugs property
… exception in Hid.node on Windows. * Fixed typos
…nt with class name
Update to latest master version
When the ColorActionProvider is the first one registered than the ModeActionProvider doesn't work anymore.
- removed NightMode - made _updateState mode independent
I removed the nightmode from the base class. |
- Updated blinkstick dependency to 1.1.3 - fix for DummyLedLight
Support for node 4.x
changed singlequotes to doublequotes in MilightRF24-example
I added a new mode to the base class "NIGHT".
Because Milight LEDs have a nightmode which means they light in white but with very little brightness.
Maybe it would be good to have the ability to add specialmodes to devices because they have a fourth mode "DISCO" with different effects.