Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate alternatives to BinaryFormatter #26

Closed
atrauzzi opened this issue Jun 4, 2022 · 5 comments · Fixed by #51
Closed

Investigate alternatives to BinaryFormatter #26

atrauzzi opened this issue Jun 4, 2022 · 5 comments · Fixed by #51
Assignees
Labels
enhancement New feature or request vulnerability Security vulnerability

Comments

@atrauzzi
Copy link

atrauzzi commented Jun 4, 2022

Got this warning earlier today through this library:

BinaryFormatter serialization and deserialization are disabled within this application. See https://aka.ms/binaryformatter for more information.

(https://aka.ms/binaryformatter)

Any chance this library could be updated to use an alternative (perhaps as suggested by the article?)?

@phnx47
Copy link
Owner

phnx47 commented Jun 6, 2022

@atrauzzi Thank you! I will investigate this

@phnx47 phnx47 self-assigned this Jun 6, 2022
@phnx47
Copy link
Owner

phnx47 commented Jun 8, 2022

It can be replaced by protobuf-net. But will generate new hashes... It can break applications that use the hash as a key.

@atrauzzi
Copy link
Author

That's a pretty heavy dependency to take on for a small lib like this.

@phnx47
Copy link
Owner

phnx47 commented Jun 14, 2022

@atrauzzi I think, that I will replace with System.Text.Json with changes in internal logic. It will be a new major version.

@phnx47 phnx47 added enhancement New feature or request vulnerability Security vulnerability labels Jun 14, 2022
phnx47 added a commit that referenced this issue Dec 23, 2022
phnx47 added a commit that referenced this issue Dec 23, 2022
@phnx47 phnx47 closed this as completed in #51 Apr 4, 2023
@phnx47
Copy link
Owner

phnx47 commented Apr 4, 2023

BinaryFormatter replaced with BinaryWriter.
Published v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vulnerability Security vulnerability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants