Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace BinaryFormatter with BinaryWriter #51

Merged
merged 39 commits into from
Apr 4, 2023
Merged

Replace BinaryFormatter with BinaryWriter #51

merged 39 commits into from
Apr 4, 2023

Conversation

phnx47
Copy link
Owner

@phnx47 phnx47 commented Apr 2, 2023

Fixes #26

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +13.20 🎉

Comparison is base (111c3f5) 86.79% compared to head (1235560) 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             main       #51       +/-   ##
============================================
+ Coverage   86.79%   100.00%   +13.20%     
============================================
  Files           2         2               
  Lines          53       123       +70     
  Branches        9         8        -1     
============================================
+ Hits           46       123       +77     
+ Misses          3         0        -3     
+ Partials        4         0        -4     
Impacted Files Coverage Δ
src/FingerprintBuilder.cs 100.00% <100.00%> (+13.51%) ⬆️
src/FingerprintBuilderExtensions.cs 100.00% <100.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phnx47 phnx47 marked this pull request as draft April 2, 2023 15:10
@phnx47 phnx47 marked this pull request as ready for review April 4, 2023 04:34
@phnx47 phnx47 merged commit dfa20d9 into main Apr 4, 2023
@phnx47 phnx47 deleted the feat/binformat branch April 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate alternatives to BinaryFormatter
1 participant