drivers/imx-enet: Add support for ethernet in imxrt1064-evk #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
3185e73 to
a582983
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
3 times, most recently
from
b8059e4 to
2af33ab
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
2af33ab to
f5e973e
Compare
nalajcie
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Partial review as current commit structure prevents efficient code review (the browser crashed with the amount of changes/comments in single commit :)).
Short summary:
- fix commit message titles (see
git historyfor examples), at least prefix them with module name (also include in commit message bodies what / why was changed), add missing JIRA ID - clearly split the changes into separate atomic commits (eg. changing type name is not bringing new functionality and should be a separate change)
- fix coding style (according to our coding convention / MISRA as described in some comments)
- please test the code after changes on imx6ull-evk and DTR project (from CI I see that something is broken there), check also if the performance is not degraded
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
f5e973e to
7dbbd7e
Compare
Unit Test Results7 958 tests +233 7 414 ✅ +404 41m 38s ⏱️ + 4m 29s For more details on these failures, see this check. Results for commit efdd19e. ± Comparison against base commit b0964a1. This pull request removes 730 and adds 963 tests. Note that renamed tests count towards both.This pull request removes 137 skipped tests and adds 36 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
7dbbd7e to
710b1d1
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
2 times, most recently
from
e11d5db to
067dc1b
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
3 times, most recently
from
8c41250 to
fc32052
Compare
|
converting to draft until it will be ready for next review |
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
fc32052 to
f42a4cc
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
2 times, most recently
from
23199d4 to
949cbf1
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
949cbf1 to
c11c661
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
c90ea6b to
6b1f87c
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
6b1f87c to
d8acbf1
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
d8acbf1 to
1242ca1
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
3 times, most recently
from
6da7579 to
5eb5717
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
5eb5717 to
6b68262
Compare
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
6b68262 to
dc60c0c
Compare
change code style to match coding conventions JIRA: RTOS-507
refactor printfs with repeated format pattern into ephy_printf JIRA: RTOS-507
JIRA: RTOS-507
JIRA: RTOS-507
first step to add separate implementation files for imx6ull and imxrt106x gpio JIRA: RTOS-507
JIRA: RTOS-507
remove active value inversion in gpio_wait because the value is already being inverted in gpio_get JIRA: RTOS-507
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
dc60c0c to
c5e6945
Compare
JIRA: RTOS-507
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
c5e6945 to
7ac9f36
Compare
This was referenced Dec 9, 2024
fix 7b90e8e: - add _Atomic specifier to volatile vars used as atomics - change operations on the vars to atomic_* JIRA: RTOS-507
fix packet buffer handling for targets with page size less than packet buffer size JIRA: RTOS-507
julianuziemblo
force-pushed
the
julianuziemblo/enet-imxrt1064-evk
branch
from
7ac9f36 to
efdd19e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Ethernet support for iMX RT106x, merging the code with existing driver for iMX 6ULL in
drivers/imx-enet.cSome tests for
armv7a7-imx6ull-evkmay not be passing without phoenix-rtos/phoenix-rtos-project#1134Motivation and Context
https://jira.phoenix-rtos.com/browse/RTOS-507
Types of changes
How Has This Been Tested?
armv7a7-imx6ull-evk,armv7m7-imxrt106x-evk,armv7a7-imx6ull-dataro.Checklist:
Special treatment