Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects/(imx6ull, imxrt106x, imxrt117x): Add ENET config #1247

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Dec 9, 2024

Description

Provide necessary default configuration for iMX RT117x Ethernet driver and adds additional config for iMX 6ULL and iMX RT106x

Motivation and Context

New target armv7m7-imxrt117x-evkb was needed because of significant differences between the PHYs and connections used on between iMX RT1170 EVK and EVKB boards.
New config was added to iMX 6ULL and RT106x plo scripts to specify the PHY chip used on the board.

Checks for target armv7a7-imx6ull-evk will not be passing because of the changes to handling the plo init script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

If the dependent project uses ENET on any of the aforementioned platforms, the PHY chip model used on board has to be added just after "PHY" string to the lwip enet init, like so:

- enet:0x02188000:150:PHY:0.2:irq:5:/dev/gpio5
+ enet:0x02188000:150:PHY:ksz8081rnb:0.2:irq:5:/dev/gpio5

Additionally, any definition for KSZ8081 symbols can be removed.

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a7-imx6ull-evk, armv7m7-imxrt106x-evk, arvmv7m7-imxrt117x-evkb (newly added by this PR).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
Declare and assign separately to avoid masking return values. SC2155

export LWIPOPTS_DIR="$(pwd)/_projects/armv7a7-imx6ull-evk/lwip"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
ERASE_SIZE appears unused. Verify use (or export if used externally). SC2034

ERASE_SIZE=$((16 * 4096)) # Rootfs disk erase block size (in bytes)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
CLEANMARKER_SIZE appears unused. Verify use (or export if used externally). SC2034

CLEANMARKER_SIZE=$((0x10)) # JFFS2 cleanmarker size (in bytes)

Copy link

github-actions bot commented Dec 9, 2024

Unit Test Results

7 958 tests  ±0   7 414 ✅  - 2   40m 39s ⏱️ - 1m 42s
  470 suites ±0     542 💤 ±0 
    1 files   ±0       2 ❌ +2 

For more details on these failures, see this check.

Results for commit 567a344. ± Comparison against base commit d7b10b7.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch 2 times, most recently from f7b41a7 to 87dfde8 Compare December 10, 2024 10:34
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from 87dfde8 to 8b4c63d Compare December 10, 2024 15:57
@julianuziemblo julianuziemblo changed the title Add new target armv7m7-imxrt117x-evkb and add new ENET config for existing targets projects/(imx6ull, imxrt106x, imxrt117x): Add ENET config Dec 16, 2024
julianuziemblo and others added 6 commits December 24, 2024 10:18
enet irq not inverted in the schematic

JIRA: RTOS-507
imx6ull-evk has 2x KSZ8081RNB instead of RNA

JIRA: RTOS-507
new ENET config includes also the PHY model used for each ENET device

JIRA: RTOS-963
… EVKB board

iMX RT117x EVK and EVKB board have significant differences (e.g. different
Ethernet PHY), so they need to be configured separately.
Also add lwip init script for iMX RT117x's ENET and ENET_1G interfaces.

JIRA: RTOS-963
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from 8b4c63d to 567a344 Compare December 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant