Skip to content

Replace composer-modifying for testing with --ignore-platform-req argument #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

maartenderie
Copy link
Contributor

I wish I didn't need to override the RD_KAFKA_VERSION const from kafka-stubs but I didn't feel like it was worth creating a new version of kafka-stubs.
Let me know what you think, even (especially?) when you reject this PR.

@makasim
Copy link
Member

makasim commented Oct 29, 2021

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main enqueue-dev repository. It is used by Composer to allow developers to depend on specific Enqueue package.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/php-enqueue/enqueue-dev

Read the contribution guide

https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md

Thank you for your contribution!

@makasim
Copy link
Member

makasim commented Oct 29, 2021

LGTM

@maartenderie
Copy link
Contributor Author

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main enqueue-dev repository. It is used by Composer to allow developers to depend on specific Enqueue package.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/php-enqueue/enqueue-dev

Read the contribution guide

https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md

Thank you for your contribution!

Thanks for getting back so fast. I'll look into that! Have a great day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants