Skip to content

Replace composer-modifying for testing with --ignore-platform-req argument #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Replace composer-modifying for testing with --ignore-platform-req argument #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1da8c8e
Break CI by removing fix_composer work-around
maartenderie Oct 28, 2021
9f77f6a
Delete fix_composer work-around file itself
maartenderie Oct 28, 2021
2684695
CI; Add 'ignore ext-rdkafka' to composer
maartenderie Oct 28, 2021
31eea19
Attempt with alternative to ramsey/composer
maartenderie Oct 28, 2021
ee3db78
Stub a high version for RD_KAFKA_VERSION while testing
maartenderie Oct 28, 2021
4f89b11
put back ramsey/composer
maartenderie Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
php-version: ${{ matrix.php }}
coverage: none

- run: php Tests/fix_composer_json.php

- uses: "ramsey/composer-install@v1"
with: # ext-rdkafka not needed for tests, and a pain to install on CI;
composer-options: "--ignore-platform-req=ext-rdkafka"

- run: vendor/bin/phpunit --exclude-group=functional
3 changes: 3 additions & 0 deletions Tests/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,8 @@
}
}

// Pretend that a high version was installed, opposed to 0.8.5 from kwn/php-rdkafka-stubs
const RD_KAFKA_VERSION = 42424242;

include_once $kafkaStubsDir.'/stubs/constants.php';
include_once $kafkaStubsDir.'/stubs/functions.php';
9 changes: 0 additions & 9 deletions Tests/fix_composer_json.php
View file
Open in desktop

This file was deleted.