Skip to content

We are using ::class which is php 5.5 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 27, 2016

No description provided.

@dbu dbu merged commit 86bc89f into php-http:master Jun 27, 2016
@sagikazarmark
Copy link
Member

Ah, okay. Clear now.

@xabbuh
Copy link
Member

xabbuh commented Jun 27, 2016

Was it possible before to use some code from the package even with PHP 5.4? Because in that case it might be a good idea to add an upgrade file to clearly document this change.

@Nyholm
Copy link
Member Author

Nyholm commented Jun 27, 2016

If you only using the puli strategy and not running tests, then you were able to use php 5,4 (I think)

Yes. We should document that. I'll might have time to do it later tonight.

For the record: PHP 5.5 is EOL within a couple of weeks (days?). We should not feel bad for dropping 5.4 support.

On 27 Jun 2016, at 17:05, Christian Flothmann notifications@github.com wrote:

Was it possible before to use some code from the package even with PHP 5.4? Because in that case it might be a good idea to add an upgrade file to clearly document this change.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dbu
Copy link
Contributor

dbu commented Jun 27, 2016 via email

@Nyholm Nyholm deleted the class-constant branch June 27, 2016 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants