Using latest version of discovery #21
Conversation
|
Hm, Why am I getting the SSL error? https://travis-ci.org/php-http/socket-client/jobs/140314897 |
| @@ -9,7 +9,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.4", | |||
| "php": "^5.5|^7.0", | |||
There was a problem hiding this comment.
I updated to 5.5 because we have a hard dependency on discovery 0.9 which is requiring 5.5.
I did change the syntax because we can't garuantee that this library will work with php 8
There was a problem hiding this comment.
I don't see why 5.5 is required: https://github.com/php-http/discovery/blob/master/composer.json#L14
There was a problem hiding this comment.
Sorry, my bad. This was missing:
php-http/discovery#60
|
SSL errors are due to certificate not up to date (i tried to do a 365days certificate, but it only generates a 10days one, need to look into this) There is a script to regenerate SSL certificates for tests, you can do it if you want. |
|
Thank you @joelwurtz. I've regenerated the SSL certs now and everything looks good. =) |
|
Lets wait for discovery 1.0. |
|
Ping @joelwurtz, Would you mind reviewing this? |
|
LGTM, Thanks ! |
|
Thank you for merging. |
No description provided.