This repository was archived by the owner on Jul 16, 2025. It is now read-only.
feat: support include tools feature to system prompt #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
yup, makes sense 👍 maybe |
Contributor
Author
|
Tbh not sure how to do this stunt with the config component 🥴 |
OskarStark
changed the title
include_tool_definitions
Member
I could give it a try, if you want |
Contributor
Author
Yes please ❤️ |
OskarStark
force-pushed
the
feature/tools-system-prompt
branch
2 times, most recently
from
f8d536c to
2afc731
Compare
chr-hertel
approved these changes
Mar 7, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
looks good 👍
docs and config changes could be follow up - up to you :)
Contributor
Author
|
I will write some docs here |
OskarStark
force-pushed
the
feature/tools-system-prompt
branch
from
2afc731 to
890f051
Compare
OskarStark
commented
Mar 7, 2025
| name: 'GPT' | ||
| version: 'gpt-4o-mini' | ||
| system_prompt: 'You are a helpful assistant that can answer questions.' # The default system prompt of the chain | ||
| include_tools: true # Include tool definitions at the end of the system prompt |
Contributor
Author
There was a problem hiding this comment.
just added this for now as "doc"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs
php-llm/llm-chainNot a fan of having it on the same level like
system_prompt, maybe we should be allowed to use sth like:and
WDYT?