Update phpunit and allow php8 #325
Conversation
… with the recommended replacement. This will hopefully easy the adoption of php8. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
@jamiehannaford @haphan please let me know if this is ok the way I did it or if you want this to be split into smaller change sets. After my most recent commit CI should finally test the code on php8, so we'll see if anything needs to be adjusted in the code. The changes so far are merely to satisfy composer platform dependencies and updating test code for a new phpunit. |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
All green. Whohoo. |
|
Let me know if this pr is ready for review. Thanks :)
…On Wed, 6 Jan 2021 at 8:56 PM, Christoph Wurst ***@***.***> wrote:
All green. Whohoo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGARMQBL3OVQ7M54A6XIJTSYRMWHANCNFSM4VVWHKIQ>
.
|
|
IMO it is: the composer now allows php8, so consumers of the package can depend on it, CI and dependencies were updated accordingly :) |
|
@haphan friendly ping 😀 if you want me to change or split anything in smaller junks just let me know :) |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
@jamiehannaford @haphan please review :) |
|
Hey there, I'm checking in for a status update on this pull request. This PR and #323 seem inactive for the past two months, so I figured that I could probably ask for an update. If there's any blockers in the way, is there something that I can do to help this project by any chance? There's a handful of things that depend on this and I'd like to contribute if possible. Best Regards, |
|
Tried this PR on my project. Works really smooth. |
|
Also tried this PR, works for us. Is there anything that is keeping it blocked from being merged? |
|
If anybody is interested in help maintain this project, please let me know. Otherwise we'll need to consider activating read-only mode. |
|
@jamiehannaford It may be worth adding a message to display in the package.json that will tell users installing the library that the package is looking for a new maintainer. I wish that I had the time to further contribute to the library myself, but I do hope that this library is maintained for how much I utilize it. |
|
@Elycin Is this possible to do with Composer? It's been a while since I've worked with PHP 😄 |
|
@jamiehannaford I believe so. Found this on StackOverflow. https://stackoverflow.com/a/61254933 P.S.: can you also tag the release if possible? |
|
Tagged v3.2.0 |
This builds on #324.
This also resolves all wrong method calls with the new phpunit and fixes and code/markup that triggers phpunit warnings otherwise. This will ease the upgrade to phpunit9.