Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with PHP 8 #80

Merged
merged 7 commits into from
Apr 5, 2021
Merged

Tests with PHP 8 #80

merged 7 commits into from
Apr 5, 2021

Conversation

sausin
Copy link
Owner

@sausin sausin commented Mar 24, 2021

No description provided.

@sausin
Copy link
Owner Author

sausin commented Mar 24, 2021

Without upstream dependencies supporting PHP 8, it seems support won't be possible as requested in #78

Ref: php-opencloud/openstack#323

@Elycin
Copy link

Elycin commented Mar 29, 2021

Hey @sausin,

Thanks for making the attempt, I've left a comment over at php-opencloud/openstack#325 (comment) asking if there's anything I can do to help contribute to accelerating the speed of upgrading that dependency. Hopefully, I'll hear something soon in regards to the active pull request (#325).

@sausin
Copy link
Owner Author

sausin commented Mar 29, 2021

@Elycin Thanks and that's awesome! Appreciated 👍

@Elycin
Copy link

Elycin commented Apr 1, 2021

Hey there, as of about two hours ago from the time I am writing this message, the dependent library has been updated.

@sausin
Copy link
Owner Author

sausin commented Apr 1, 2021

@Elycin thanks for the update! It seems that a new release hasn't yet been tagged and so the tests are still failing. Let's hope one gets tagged soon

@Elycin
Copy link

Elycin commented Apr 3, 2021

Tagged! https://github.com/php-opencloud/openstack/releases/tag/v3.2.0

It's not exactly a proper release, and the author is looking to potentially archive the repository, do you think we should make the versioning dev-master@3.2.0, or potentially consider forking it and maintaining it on our own?

@sausin
Copy link
Owner Author

sausin commented Apr 4, 2021

@Elycin Thank you for doing the followup there! I've had to update the test setup as there were quite a bit of errors due to isArray() deprecation in PHP 8.

While the older laravel versions will still 'work', it's probably better to tag 6.x on the package to bring clarity that older laravel verions won't be actively supported.

Regarding openstack, a fork to maintain only for the purpose of this package's scope could be a good option. We can just focus on keeping it functional for a specific purpose and thereby limiting the effort needed on support. Unfortunately, I feel that I won't have the time to help out on the main openstack repository.

We can also take thoughts of @iksaku on this.

@sausin sausin merged commit 3d842d1 into master Apr 5, 2021
@sausin sausin deleted the php-8-github-workflow branch April 5, 2021 16:51
@sausin
Copy link
Owner Author

sausin commented Apr 5, 2021

Have tagged 6.0.0. We can still continue the discussion on the openstack here :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants