Travis: add build against PHP 8.0 and fix failing test #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.0 has been branched off two months ago, so `nightly` is now PHP 8.1 and in the mean time PHP 8.0 was released last week. As of today, there is a PHP 8.0 image available on Travis. This PR adds a new build against PHP 8.0 to the matrix and, as PHP 8.0 has been released, that build is not allowed to fail.
This test is expected to throw a deprecation warning for the PHP4-style class constructor (method named the same as the class). In PHP 8, the deprecation warning is no longer thrown and PHP4-style constructor method are now treated as _normal_ methods. This fixes the test to have the correct expectations.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis: add build against PHP 8.0
PHP 8.0 has been branched off two months ago, so
nightlyis now PHP 8.1 and in the mean time PHP 8.0 was released last week.As of today, there is a PHP 8.0 image available on Travis.
This PR adds a new build against PHP 8.0 to the matrix and, as PHP 8.0 has been released, that build is not allowed to fail.
ParallelLintLintTest::testDeprecated(): fix the test
I previously pointed out in #5 that this test was failing, but clearly no action has been taken on that in the mean time. Either way, fixing this now.
This test is expected to throw a deprecation warning for the PHP4-style class constructor (method named the same as the class).
In PHP 8, the deprecation warning is no longer thrown and PHP4-style constructor method are now treated as normal methods.
This fixes the test to have the correct expectations.