Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis: add build against PHP 8.0 and fix failing test #41

Merged
merged 2 commits into from
Dec 27, 2020
Merged

Travis: add build against PHP 8.0 and fix failing test #41

merged 2 commits into from
Dec 27, 2020

Commits on Dec 4, 2020

  1. Travis: add build against PHP 8.0 

    PHP 8.0 has been branched off two months ago, so `nightly` is now PHP 8.1 and in the mean time PHP 8.0 was released last week.

As of today, there is a PHP 8.0 image available on Travis.

This PR adds a new build against PHP 8.0 to the matrix and, as PHP 8.0 has been released, that build is not allowed to fail.
    @jrfnl
    jrfnl committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    76e16c2 View commit details
    Browse the repository at this point in the history

  2. ParallelLintLintTest::testDeprecated(): fix the test 

    This test is expected to throw a deprecation warning for the PHP4-style class constructor (method named the same as the class).

In PHP 8, the deprecation warning is no longer thrown and PHP4-style constructor method are now treated as _normal_ methods.

This fixes the test to have the correct expectations.
    @jrfnl
    jrfnl committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    13e006e View commit details
    Browse the repository at this point in the history