Added GitHub Actions for testing #20
Conversation
There was a problem hiding this comment.
@grogy Nicely done.
I've left a couple of suggestions inline.
I'd also like to suggest adding the following to cancel older builds for the same branch when a new commit has been pushed:
# Cancels all previous workflow runs for the same branch that have not yet completed.
concurrency:
# The concurrency group contains the workflow name and the branch name.
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true| - '7.1' | ||
| - '7.2' | ||
| - '7.3' | ||
| - '7.4' |
There was a problem hiding this comment.
What about adding PHP 8.0, 8.1 and 8.2 ?
For PHP 8.2, you could then change the continue-on-error: ${{ matrix.experimental == true }} setting to: continue-on-error: ${{ matrix.php == '8.2' }} to allow builds against PHP 8.2 to fail while it is still under development.
There was a problem hiding this comment.
PHP 8.x will be added in next step. I want convert 1:1 state previous TravisCI state
There was a problem hiding this comment.
For 8.x is necessary add support, via https://github.com/php-parallel-lint/PHP-Var-Dump-Check/runs/5065543774?check_suite_focus=true
There was a problem hiding this comment.
That's fair enough. I'm actually tempted to suggest abandoning this repo in favour of a PHP_CodeSniffer sniff for the same at some point in the future. Should make PHP cross-version support easier ;-)
grogy
force-pushed
the
github-actions
branch
5 times, most recently
from
6c43c0b to
573db39
Compare
|
Please, can you review fixes? |
| - '7.1' | ||
| - '7.2' | ||
| - '7.3' | ||
| - '7.4' |
There was a problem hiding this comment.
That's fair enough. I'm actually tempted to suggest abandoning this repo in favour of a PHP_CodeSniffer sniff for the same at some point in the future. Should make PHP cross-version support easier ;-)
It replaced unused TravisCI.
|
Oops, sorry, forgot to do rebase merge..... |
It replaced unused TravisCI. I inspired in PHP-Parallel-Lin from @jrfnl
Fixes #19