-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GitHub Actions for testing #20
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| /.github export-ignore | ||
| /tests export-ignore | ||
| .gitattributes export-ignore | ||
| .gitignore export-ignore | ||
| .travis.yml export-ignore | ||
| phpunit.xml.dist export-ignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: Run unit tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| # Allow manually triggering the workflow. | ||
| workflow_dispatch: | ||
|
|
||
| # Cancels all previous workflow runs for the same branch that have not yet completed. | ||
| concurrency: | ||
| # The concurrency group contains the workflow name and the branch name. | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Run tests on PHP ${{ matrix.php }} | ||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| php: | ||
| - '5.4' | ||
| - '5.5' | ||
| - '5.6' | ||
| - '7.0' | ||
| - '7.1' | ||
| - '7.2' | ||
| - '7.3' | ||
| - '7.4' | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php }} | ||
| ini-values: zend.assertions=1, error_reporting=-1, display_errors=On | ||
| coverage: none | ||
jrfnl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| tools: cs2pr | ||
|
|
||
| - name: Install Composer dependencies | ||
| uses: ramsey/composer-install@v2 | ||
|
|
||
| - name: 'Linting code' | ||
| run: ./vendor/bin/parallel-lint --exclude vendor . --exclude git . --checkstyle | cs2pr | ||
|
|
||
| - name: 'Run unit tests' | ||
| run: ./vendor/bin/phpunit | ||
|
|
||
| - name: 'Check var dump on own code' | ||
| run: ./var-dump-check src | ||
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about adding PHP
8.0,8.1and8.2?For PHP 8.2, you could then change the
continue-on-error: ${{ matrix.experimental == true }}setting to:continue-on-error: ${{ matrix.php == '8.2' }}to allow builds against PHP 8.2 to fail while it is still under development.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP 8.x will be added in next step. I want convert 1:1 state previous TravisCI state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 8.x is necessary add support, via https://github.com/php-parallel-lint/PHP-Var-Dump-Check/runs/5065543774?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair enough. I'm actually tempted to suggest abandoning this repo in favour of a PHP_CodeSniffer sniff for the same at some point in the future. Should make PHP cross-version support easier ;-)