Skip to content

Fix https://github.com/php-pm/php-pm-httpkernel/issues/34 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2016
Merged

Fix https://github.com/php-pm/php-pm-httpkernel/issues/34 #35

merged 1 commit into from
May 2, 2016

Conversation

andig
Copy link
Contributor

@andig andig commented Apr 29, 2016

Fix #34

@andig andig force-pushed the deps branch 3 times, most recently from fb5c83f to 2d40a62 Compare April 30, 2016 10:19
@andig
Copy link
Contributor Author

andig commented Apr 30, 2016

Wait a moment, need to add the implements clause for Drupal as well.

@andig
Copy link
Contributor Author

andig commented Apr 30, 2016

Wait a moment, need to add the implements clause for Drupal as well.

Fixed. Should be good now.

@andig
Copy link
Contributor Author

andig commented May 2, 2016

ping @marcj ok to go?

@marcj
Copy link
Member

marcj commented May 2, 2016

LGTM 👍

@marcj marcj merged commit 09fb0ae into php-pm:master May 2, 2016
@andig andig deleted the deps branch May 2, 2016 11:49
@andig
Copy link
Contributor Author

andig commented May 2, 2016

Excellent, much appreciated.

@bratao bratao mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andig @marcj