Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] Add new Sodium functions and constants #3878

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

MauricioFauth
Copy link
Member

Constants:

  • SODIUM_CRYPTO_AEAD_AEGIS128L_KEYBYTES
  • SODIUM_CRYPTO_AEAD_AEGIS128L_NSECBYTES
  • SODIUM_CRYPTO_AEAD_AEGIS128L_NPUBBYTES
  • SODIUM_CRYPTO_AEAD_AEGIS128L_ABYTES
  • SODIUM_CRYPTO_AEAD_AEGIS256_KEYBYTES
  • SODIUM_CRYPTO_AEAD_AEGIS256_NSECBYTES
  • SODIUM_CRYPTO_AEAD_AEGIS256_NPUBBYTES
  • SODIUM_CRYPTO_AEAD_AEGIS256_ABYTES

Functions:

  • sodium_crypto_aead_aegis128l_decrypt()
  • sodium_crypto_aead_aegis128l_encrypt()
  • sodium_crypto_aead_aegis128l_keygen()
  • sodium_crypto_aead_aegis256_decrypt()
  • sodium_crypto_aead_aegis256_encrypt()
  • sodium_crypto_aead_aegis256_keygen()

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimwins @cmb69 should we start enforcing using <simpara> for things that can use it? (Which here would basically mean converting all of them)

@cmb69
Copy link
Member

cmb69 commented Oct 22, 2024

should we start enforcing using <simpara> for things that can use it?

I'd say yes. Although we need to be careful with the rendering (I've checked function.sodium-crypto-aead-aegis128l-decrypt.php, and that looks fine). And we should probably also update the skeletons, and doc-gen templates.

@Girgias
Copy link
Member

Girgias commented Oct 22, 2024

I'll update the templates today

@jimwins
Copy link
Member

jimwins commented Oct 22, 2024

@jimwins @cmb69 should we start enforcing using <simpara> for things that can use it? (Which here would basically mean converting all of them)

Yeah. I've proposed an addition to the style guidelines to address this, too.

php/doc-base#168

@Girgias Girgias merged commit 01cb7d4 into php:master Oct 23, 2024
2 checks passed
@MauricioFauth MauricioFauth deleted the sodium-php84 branch October 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants