Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.4] Add mb_* functions #3922

Merged
merged 5 commits into from
Oct 24, 2024
Merged

[PHP 8.4] Add mb_* functions #3922

merged 5 commits into from
Oct 24, 2024
+565 −219

Conversation

saundefined
Copy link
Member

No description provided.

@saundefined saundefined added this to the PHP 8.4 milestone Oct 24, 2024
@saundefined saundefined mentioned this pull request Oct 24, 2024
Open
Girgias
Girgias requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markup changes that need to be replicated to all new files.

language-snippets.ent Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-lcfirst.xml Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-lcfirst.xml Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-lcfirst.xml Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-lcfirst.xml Outdated Show resolved Hide resolved
@youkidearitai
Copy link
Contributor

Thank you very much for adding mb_* functions.

Note: mb_trim, mb_ltrim and mb_rtrim functions signature are changed from RFC https://wiki.php.net/rfc/mb_trim to php/php-src#13820

@saundefined @Girgias @youkidearitai
[PHP 8.4] Add mb_* functions
4e94510 
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Co-authored-by: tekimen <youkidearitai@gmail.com>
Girgias
Girgias requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More remarks and markup nits

reference/mbstring/functions/mb-ltrim.xml Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-lcfirst.xml Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-lcfirst.xml Outdated Show resolved Hide resolved
language-snippets.ent Outdated Show resolved Hide resolved
saundefined and others added 2 commits October 24, 2024 23:19
@saundefined @Girgias
Apply suggestions from code review
c3d65aa 
Co-authored-by: Gina Peter Banyard <girgias@php.net>
@saundefined @Girgias
Move characters parameter to entity
e575fe8 
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Girgias
Girgias approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final markup review, but LGTM otherwise.

language-snippets.ent Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-rtrim.xml Outdated Show resolved Hide resolved
reference/mbstring/functions/mb-trim.xml Outdated Show resolved Hide resolved
@saundefined @Girgias
Apply suggestions from code review
c65d77f 
Co-authored-by: Gina Peter Banyard <girgias@php.net>
@saundefined
Copy link
Member Author

Thanks a lot!

@saundefined saundefined merged commit 27ae0a4 into php:master Oct 24, 2024
2 checks passed
@saundefined saundefined deleted the php84-mb-functions branch October 24, 2024 20:33
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 7, 2024
Open
48 tasks
@youkidearitai youkidearitai mentioned this pull request Nov 8, 2024
Merged
@jdkfx jdkfx mentioned this pull request Nov 14, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@saundefined @youkidearitai @Girgias